Skip to content

Ensure that the output sizes do not exceed file/console sizes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YUKI2eN3e
Copy link

No description provided.

@mintty
Copy link
Owner

mintty commented Oct 29, 2023

As far as I can see (missing a description), the script tries to scale the image to the terminal size, scaling down or up as needed. While this may be a nice feature, it is not the intent of the original script. Consider that people may want to see multiple images on their screen, and test what an application might look like that mixes images into output.
It could be a variation, though, maybe an option, and also a useful option would be to scale down only, not up.

@YUKI2eN3e
Copy link
Author

Ok, what I was trying to do was to have it use the -width and -height inputs as long as they don't exceed what the console can show (or are larger than the file being shown). So multiple images should be fine, at least it worked for me, but since I don't do a lot of bash scripting I can't say for sure.
showimg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants