Skip to content

Add audit log entry for kubeconfig download events #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsmiso-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add audit log entry for kubeconfig download events #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions kubetix-api/kubetix_api/grants/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ def get_grant(grant_id: str, current_user: User, db) -> GrantWithKubeconfig:
fernet = _get_fernet()
kubeconfig = fernet.decrypt(grant.encrypted_kubeconfig.encode()).decode()

# Log the download event in the audit log
audit_log = AuditLog(
user_id=current_user.id,
grant_id=grant.id,
action="downloaded",
details=f"Downloaded kubeconfig for cluster '{grant.cluster_name}'",
)
db.add(audit_log)
db.commit()

return GrantWithKubeconfig(
id=grant.id,
cluster_name=grant.cluster_name,
Expand Down
34 changes: 34 additions & 0 deletions tests/unit/test_api_audit_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,33 @@ def test_audit_log_contains_grant_revocation(
revoke_entries = [log for log in logs if log["action"] == "revoked"]
assert len(revoke_entries) >= 1

def test_audit_log_contains_grant_download(
self, client, db, auth_headers, monkeypatch
):
with tempfile.NamedTemporaryFile(
mode="w", suffix=".kubeconfig", delete=False
) as f:
f.write("apiVersion: v1\nkind: Config\n")
kubeconfig_path = f.name
monkeypatch.setenv("KUBECONFIG", kubeconfig_path)
client.post(
"/grants",
json={"cluster_name": "download-test-cluster", "role": "view"},
headers=auth_headers,
)
grants_response = client.get("/grants", headers=auth_headers)
grant_id = grants_response.json()[0]["id"]
download_response = client.get(
f"/grants/{grant_id}/download", headers=auth_headers
)
assert download_response.status_code == 200
os.unlink(kubeconfig_path)
audit_response = client.get("/audit", headers=auth_headers)
logs = audit_response.json()
download_entries = [log for log in logs if log["action"] == "downloaded"]
assert len(download_entries) >= 1
assert "download-test-cluster" in download_entries[0]["details"]

def test_audit_log_fields(self, client, db, auth_headers, monkeypatch):
with tempfile.NamedTemporaryFile(
mode="w", suffix=".kubeconfig", delete=False
Expand Down Expand Up @@ -225,17 +252,24 @@ def test_full_lifecycle_audit_trail(self, client, db, auth_headers, monkeypatch)
)
assert create_response.status_code == 201
grant_id = create_response.json()["id"]
download_response = client.get(
f"/grants/{grant_id}/download", headers=auth_headers
)
assert download_response.status_code == 200
os.unlink(kubeconfig_path)
revoke_response = client.delete(f"/grants/{grant_id}", headers=auth_headers)
assert revoke_response.status_code == 204
audit_response = client.get("/audit", headers=auth_headers)
logs = audit_response.json()
actions = [log["action"] for log in logs]
assert "created" in actions
assert "downloaded" in actions
assert "revoked" in actions
created_entry = next(log for log in logs if log["action"] == "created")
downloaded_entry = next(log for log in logs if log["action"] == "downloaded")
revoked_entry = next(log for log in logs if log["action"] == "revoked")
assert created_entry["grant_id"] == grant_id
assert downloaded_entry["grant_id"] == grant_id
assert revoked_entry["grant_id"] == grant_id

def test_audit_log_grant_id_present(self, client, db, auth_headers, monkeypatch):
Expand Down