feat(deps)!: Update dependency jsdom (29.1.1 → 30.0.0)#671
feat(deps)!: Update dependency jsdom (29.1.1 → 30.0.0)#671its-miso[bot] wants to merge 1 commit into
Conversation
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_request_changes,fast_low_confidence)
Review: jsdom 29.1.1 → 30.0.0
Recommendation: Request changes — CI pipeline has not completed. The Docker Build check has FAILED and the full test suite remains PENDING. This PR cannot be approved until CI passes.
Change Summary
This Renovate PR bumps the jsdom dev dependency from ^29.1.1 to ^30.0.0. The change affects package.json and package-lock.json. Several transitive dependencies are also updated:
@asamuzakjp/css-color: 5.1.11 → 6.0.5@asamuzakjp/dom-selector: 7.1.1 → 8.3.0@asamuzakjp/generational-cache: removed (consolidated into dom-selector)@asamuzakjp/nwsapi: removed (consolidated into dom-selector)undici: 7.28.0 → 8.9.0lru-cache: 11.3.5 → 11.5.2
Required Checks
✅ check for breaking API changes in updated dependencies
The jsdom v30.0.0 release notes (Source 10) identify one breaking change: the Node.js minimum version floor was raised to ^22.22.2 || ^24.15.0 || >=26.0.0. No breaking changes to jsdom's public API are documented.
The repository's Dockerfile specifies node:24-bookworm-slim, which satisfies the new Node.js requirement (Node 24.15.0 ≥ 24.15.0). This is confirmed by recent commit 620f1fb that upgraded from Node 20 to 24.15.0.
No other API-surface breaking changes were identified in the release notes or the 11 commits between v29.1.1 and v30.0.0.
❌ run full test suite after upgrade
Status: NOT VERIFIED. CI shows:
Tests: pendingBuild: pendingLint: pendingTypecheck: pendingDocker Build: failure
The full test suite has not run. The Docker Build failure must be resolved before this PR can merge.
Standards Compliance
- Node.js host platform compatibility: jsdom 30.0.0 requires
^22.22.2 || ^24.15.0 || >=26.0.0. The repository pinsnode:24-bookworm-slimin the Dockerfile (AGENTS.md confirms: "Base image:node:24-bookworm-slim"), and git history shows commit620f1fbbumping Node from 20.20.2 to 24.15.0. The host platform version satisfies jsdom 30.0.0's requirement. - No code conventions violated: This is a pure dependency version bump in
package.json/package-lock.json, consistent with repository patterns.
Unknowns / Needs Verification
- Root cause of Docker Build failure: The CI shows
Docker Build: failurebut no error details are provided in the corpus. The failure could be unrelated to jsdom (e.g., a caching issue, network timeout) or could be a real incompatibility. This must be diagnosed before merging. - Tests, Build, Lint, Typecheck: All PENDING. The complete CI pipeline must pass before approval.
Conclusion
This PR is a routine major-version bump of a dev-only dependency with no breaking API surface changes and a Node.js version floor compatible with the repository's pinned base image. However, the PR cannot be approved because CI has not completed: the Docker Build check has failed and the full test suite (Tests, Build, Lint, Typecheck) remains pending. Request changes pending CI resolution.
This PR contains the following updates:
^29.1.1→^30.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
jsdom/jsdom (jsdom)
v30.0.0Compare Source
Breaking changes:
^22.22.2 || ^24.15.0 || >=26.0.0.Other changes:
CSS.escape()andCSS.supports()functions. (@asamuzaK)'background-position-x'and'background-position-y'CSS properties. (@olagokemills)getComputedStyle()to convert length values into pixels. (@asamuzaK)getPropertyValue(). (@asamuzaK)document.evaluate()(@dokson)Configuration
📅 Schedule: (in timezone America/Edmonton)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.