fix: add workflow_dispatch trigger to release pipeline - #11
Merged
Conversation
itsmiso-ai
added a commit
that referenced
this pull request
Jul 8, 2026
When the worker cap (BASE_WORKER_CAP + 2 per completed hut) exceeded the 10-entry WORKER_NAMES pool, recruit_worker cycled back to bare names like "Jun" and produced duplicates (e.g. worker #11 collided with worker #1). recruit_worker now appends a numeric seed once we've cycled past the first round ("Jun11", "Mara12", …) and tracks a `base_name` field on every worker dict so that: - bootstrap_state seeds base_name on the initial 10 workers, - render_sidebar's badge color lookup uses base_name, - render_worker_sprites / render_worker_overlay pass base_name to worker_texture so all "Jun*" workers share the same sprite cache entry and the same badge color as cycle-1 "Jun". Added tests/test_recruit_worker_pool_overflow.gd as a regression test: with five completed huts (cap = 12) it recruits pool_size + 1 workers, asserts that cycle-1 names stay bare, that the overflow worker gets the expected numeric suffix, that all names remain unique, and that the overflow worker's base_name resolves to a real WORKER_BADGE_COLORS entry. Fixes #247 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds workflow_dispatch so we can manually trigger the Release workflow for testing. Will allow manual dispatch at https://github.com/joryirving/windowstead/actions/workflows/release.yml