Expand WORKER_NAMES pool and add badge colors for all workers

[itsmiso-ai]

Expanded WORKER_NAMES from 2 to 10 names and added corresponding badge colors to prevent duplicate worker names when worker cap exceeds 2.

Fixes #227

Opened by foreman on review GO (workload wl-misospace-windowstead-227).

[its-saffron]

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_low_confidence)

Review Summary

Recommendation: Approve. This PR cleanly implements Option 1 from issue PR 227 — expanding the worker name pool from 2 to 10 names and adding corresponding badge colors. The change is minimal, well-tested, and fully satisfies all acceptance criteria.

---

Change-by-Change Findings

scripts/constants.gd

• Expanded WORKER_NAMES from 2 entries to 10: ["Jun", "Mara", "Kai", "Lia", "Ren", "Sia", "Nia", "Tao", "Yun", "Zoe"]
• Added 8 new badge colors to WORKER_BADGE_COLORS for all new names, each with a distinct hex color
• No other constants were touched; change is precisely scoped to the reported issue

tests/test_constants.gd

• Updated _test_worker_names_count() to expect 10 entries (was 2)
• Added _test_worker_names_all() to verify the exact array matches expectations
• Updated _test_badge_color_count() to expect 10 entries
• Added _test_badge_colors_complete() which iterates WORKER_NAMES and verifies each has a corresponding entry in WORKER_BADGE_COLORS — directly satisfies acceptance criterion PR 2
• Added blank lines between test functions per GDScript conventions

tests/test_recruit_worker.gd

• Updated test_recruit_cycles_through_names to expect "Kai" at index 2 instead of "Jun" (correct given the expanded pool)
• Added test_recruit_unique_names() which recruits 4 workers (with a hut setup giving cap=4) and asserts all names are unique via sort+dedup — directly satisfies acceptance criterion PR 1

---

Standards Compliance

✅ Repository conventions followed:

• Tests use the established _assert_eq() helper pattern from the existing test files
• Blank lines added between GDScript functions (conventional style in this codebase)
• No violations of AGENTS.md, CONTRIBUTING.md, or CLAUDE.md requirements
• Change is scoped, focused, and appropriately small (87 additions / 8 deletions)

✅ No regressions detected:

• CI passed all three gates: macOS validation, headless smoke test, script test suite

---

Linked Issue Fit

Issue PR 227 acceptance criteria:

Criterion	Status
No two active workers share the same name	✅ Verified by test_recruit_unique_names() — recruits 4 workers and asserts all names are unique
WORKER_BADGE_COLORS has an entry for every name in WORKER_NAMES	✅ Verified by test_badge_colors_complete() — iterates all names and checks badge map coverage
Names fit the game's tone (short, casual, cozy)	✅ All 10 names are 3-4 characters, easy to read, and match the casual tone of "Jun" and "Mara"

The PR implements the recommended Option 1 from the issue and is consistent with the issue's implementation guidance.

---

Evidence Provider Findings

No evidence providers configured for this PR.

---

Tool Harness Findings

• gh_api for scripts/main.gd on the wrong repo (mispospace instead of misospace) failed, but the actual file was fetched successfully from the correct repo
• The diff is self-contained and does not require reading main.gd to verify correctness

---

Unknowns / Needs Verification

None. The diff fully covers the implementation, tests are comprehensive, and CI is green.