Add Windows and macOS export build steps to CI - #264
Conversation
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Superseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Superseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T21:36:10.616Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T21:51:10.395Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T22:06:10.215Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T22:21:10.004Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T22:36:10.341Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T22:51:10.247Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T23:06:10.173Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T23:21:10.036Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T23:36:10.156Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-08T23:51:10.130Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T00:06:10.305Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T00:21:10.253Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T00:36:10.288Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T00:51:10.149Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T01:06:10.148Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T01:21:10.048Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T01:36:09.956Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T01:51:10.265Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T02:06:10.398Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T02:21:10.474Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T02:36:09.970Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T14:21:10.764Z |
Reason: Failing check: Export validation (macOS) (failure) Latest note: foreman fix exhausted 3/3 attempts on ESCALATED (all coder tiers exhausted) (prfix-misospace-windowstead-264) Posted automatically by Dispatch on 2026-07-09T14:30:03.896Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T14:51:10.856Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T15:06:10.639Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T15:17:43.163Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T15:26:30.367Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T15:32:41.568Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T15:47:41.502Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T16:02:41.697Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T16:17:41.335Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T16:32:41.525Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T16:47:41.331Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T17:02:41.591Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T17:17:41.348Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T17:20:21.207Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T17:32:41.927Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T17:47:41.741Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T18:02:47.867Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T18:17:41.829Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T18:32:41.761Z |
Reason: PR review: CHANGES_REQUESTED Posted automatically by Dispatch on 2026-07-09T18:47:41.320Z |
Superseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add export-validation-windows and export-validation-macos jobs following the existing Linux export-validation pattern. The Windows job uses the Linux Godot binary on ubuntu-latest for cross-compilation (matching release.yml). The macOS job runs on macos-latest with the native Godot .app bundle. The macOS validation checks for the correct executable name 'windowstead' inside Contents/MacOS/ rather than 'Godot', which is what Godot 4.x produces when exporting a macOS app bundle. Fixes #254 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
2593720 to
5e3cbb7
Compare
Superseded by a newer automated review for this pull request.
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_low_confidence)
Recommendation: Approve
This PR adds Windows and macOS export validation jobs to CI, directly addressing issue PR 254. The implementation follows the established Linux export-validation pattern with consistent tooling, error handling, and verification.
Change-by-Change Findings
.github/workflows/test.yml (+105 lines)
export-validation-windows job (lines 279-332)
- Uses
ubuntu-latestrunner (correct for Godot's cross-compilation capability) - Reuses
load-godot-toolchainaction for version/templating configuration - Downloads Linux Godot binary, verifies SHA256 checksum
- Installs export templates to the standard Godot path
- Exports "Windows Desktop" build to
build/export-validation/windows/ - Verifies
windowstead.exeandwindowstead.pckare present and non-empty
export-validation-macos job (lines 335-383)
- Uses
macos-latestrunner (required for native Godot.app execution) - Downloads and installs both Godot templates and macOS binary
- Uses
findto locateGodot.appin the downloaded archive with explicit error handling - Exports "macOS" build to
build/export-validation/macos/windowstead.app - Verifies the
.appbundle exists and contains the executable atContents/MacOS/windowstead
Sources
- PR body: "Adds Windows and macOS export validation jobs to CI, following the existing Linux export-validation pattern. Fixes PR 254"
- CI Check Results: All six checks passed (headless smoke test, script tests, macOS validation, export validation for all three platforms)
- Git history: Commits show the Linux-only precursor (PR 240) and subsequent cross-platform additions
Standards Compliance
- Pattern consistency: Follows the exact structure of the existing
export-validation(Linux) job — same action usage, sameset -euo pipefailshell options, same checksum verification viashasum -a 256 -c, same directory layout underbuild/export-validation/ - Toolchain action: Uses
load-godot-toolchain(consistent with all other jobs in the workflow) - Checkout action: Uses
actions/checkout@v7(consistent with other jobs) - No product code changes: This is a CI-only chore — no impact on game logic, UX, or save format
Linked Issue Fit
Issue PR 254 ("Add export build step to CI") was an audit recommendation for tech debt cleanup. The PR body explicitly references the issue, and the PR closes it by extending the Linux-only validation (added in PR 240) to cover Windows and macOS. This satisfies the original intent.
Evidence Provider Findings
No evidence providers configured for this repository.
Tool Harness Findings
No tool harness findings present.
CI Verification
The CI check results table confirms all six jobs passed on commit 5e3cbb7:
- Headless smoke test ✓
- Script test suite ✓
- macOS validation ✓
- Export validation (macOS) ✓
- Export validation (Windows) ✓
- Export validation (Linux) ✓
Unknowns / Needs Verification
None — the PR is self-contained CI infrastructure with confirmed successful runs.
Checklist
- must_check items: None specified in PR classification
- Issue PR 254 addressed: Windows and macOS export jobs added, CI green
- Repository conventions followed: Pattern matches existing Linux export job exactly
- No product regressions: CI-only change, no game logic touched
- CI checks passing: All six checks succeeded
- Checksum verification present: Both new jobs include SHA256 verification for downloads
2 participants
Adds Windows and macOS export validation jobs to CI, following the existing Linux export-validation pattern.
Fixes #254
Opened by foreman on review GO (workload wl-misospace-windowstead-254).