Skip to content

Refactor: Replace deprecated % string formatting in game_state.gd print statements #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joryirving merged 1 commit into from
Aug 1, 2026
Merged

Refactor: Replace deprecated % string formatting in game_state.gd print statements #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/game_state.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func load_game(path: String = "") -> Dictionary:
# Validate schema before migration
var validation_result := validate_save_schema(parsed)
if not validation_result.valid:
print("SAVE_SCHEMA_VALIDATION_ERROR: %s" % validation_result.reason)
print("SAVE_SCHEMA_VALIDATION_ERROR: ", validation_result.reason)
return {}

var migrated := migrate_save(parsed)
Expand Down Expand Up @@ -407,7 +407,7 @@ func migrate_save(data: Dictionary) -> Dictionary:

# Reject unknown or future versions explicitly
if save_version > SAVE_VERSION:
print("SAVE_MIGRATION_ERROR: unknown future version %d (expected <=%d)" % [save_version, SAVE_VERSION])
print("SAVE_MIGRATION_ERROR: unknown future version ", save_version, " (expected <=", SAVE_VERSION, ")")
return {}

# Version 0: treat as invalid/unsupported
Expand All @@ -425,7 +425,7 @@ func migrate_save(data: Dictionary) -> Dictionary:
return data

@its-saffron its-saffron Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Blocker (bug): String placeholder {save_version} is printed literally instead of being substituted with the save_version value. Same interpolation bug as line 410.

Automated finding from AI PR review.

@its-saffron its-saffron Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still open after this push; carried forward. (as of f6f6382)

# Fallback: should not reach here, but handle defensively
print("SAVE_MIGRATION_ERROR: unhandled save version %d" % save_version)
print("SAVE_MIGRATION_ERROR: unhandled save version ", save_version)
return {}

@its-saffron its-saffron Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Blocker (bug): Indentation error: extra leading whitespace (8 tabs) before the unhandled-save-version print() call. This will cause a GDScript parse/syntax error and is the likely cause of CI failures.

Automated finding from AI PR review.

@its-saffron its-saffron Bot Aug 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still open after this push; carried forward. (as of b9a097d)

func migrate_v1_to_v2(data: Dictionary) -> Dictionary:
Expand Down