joryirving/windowstead #53: fix tiles rendering taller than wide - #56
Conversation
|
✅ Automated recommendation: APPROVE Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1 Review: fix tiles rendering taller than wide (PR #56)SummaryThis PR makes two targeted changes to Changes1. Tile panel clip_children (line 255)
2. VBoxContainer size_flags_vertical (line 276)
AnalysisCorrectness: Both changes are syntactically correct GDScript. Consistency: Both changes serve the same goal—preventing vertical stretching—and are mutually reinforcing. The Repository alignment: This fix aligns with the "Tile-first dock sizing" principle in CLAUDE.md, ensuring square tile geometry is maintained rather than distorted. Evidence verification: The Standards Compliance
Unknowns / Needs VerificationNone. The changes are self-contained, syntactically valid, and the PR description clearly documents the intent of both modifications. |
ce7e1ad to
2665ad1
Compare
Fixes #53. Partial fix — two changes to prevent tiles from stretching vertically: (1) Changed VBoxContainer size_flags_vertical from SIZE_EXPAND_FILL to SIZE_SHRINK_END so the tile content no longer requests vertical expansion, (2) Added clip_children = ALWAYS to tile panels to prevent label content overflow from distorting the tile aspect ratio.