Skip to content

joryirving/windowstead #49: tighten bottom dock padding for better world strip fill - #57

Merged
joryirving merged 1 commit into
mainfrom
fix/issue-49-bottom-strip-fill
Apr 18, 2026
Merged

joryirving/windowstead #49: tighten bottom dock padding for better world strip fill#57
joryirving merged 1 commit into
mainfrom
fix/issue-49-bottom-strip-fill

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Fixes #49. Partial fix — reduced BOTTOM_DOCK_PADDING from Vector2i(48, 110) to Vector2i(32, 72) to tighten the bottom world strip's fill within its dock. Horizontal padding reduced by 33% (48→32px each side), vertical padding reduced by 35% (110→72px). Preserves geometry-derived tile sizing from #39.

@smurf-bot

smurf-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Automated recommendation: APPROVE

Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1

PR Review: Tighten Bottom Dock Padding (Issue #49)

Recommendation: Approve

This is a clean, focused change that reduces BOTTOM_DOCK_PADDING from Vector2i(48, 110) to Vector2i(32, 72), achieving roughly 33% horizontal and 35% vertical padding reduction for the bottom dock.

Change Summary

  • File: scripts/main.gd
  • Type: Single constant value modification
  • Impact: Reduces padding chrome around the world strip in bottom dock mode

Standards Compliance

Conforms to repository conventions:

  1. Tile-first dock sizing: The PR body explicitly states "Preserves geometry-derived tile sizing from Make dock sizing derive from tile geometry instead of the other way around #39" — consistent with the architecture established in PR windowstead #39: derive dock size from tile geometry #48.

  2. "Bottom dock should stay shallow and wide" (CLAUDE.md): Reducing vertical padding (110→72) while also reducing horizontal padding directly supports keeping the dock shallower with more space for the game world.

  3. "Denser strip filling" (Open Work Themes): This change explicitly addresses the stated open work theme by reducing dead space around the world strip.

  4. "Dense tile strip with minimal dead space" (UX Constraints): The reduction in padding directly reduces dead space around the game strip.

  5. Consistent with recent architecture: Git log shows this builds on PR windowstead #39: derive dock size from tile geometry #48 (tile-first dock sizing), maintaining the tile-geometry-first approach rather than sizing the dock independently.

Technical Observations

  • No syntax issues — GDScript constant assignment is valid
  • No breaking changes — purely visual/layout adjustment
  • No save migration needed
  • No dependency on external resources

Unknowns / Needs Verification

  • Runtime validation: No test results or headless validation provided. Repository standards mention running ./.tools/Godot_v4.2.2-stable_linux.x86_64 --headless --path . --script res://tests/test_runner.gd for validation.
  • Visual confirmation: No screenshots or visual evidence included to verify the change produces the intended "better world strip fill" result.
  • Cross-platform impact: macOS runtime validation has been important in this repo per AGENTS.md notes.

Sources

@joryirving
joryirving merged commit ca2b3b6 into main Apr 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the bottom world strip fill its dock more intentionally

2 participants