You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes#49. Partial fix — reduced BOTTOM_DOCK_PADDING from Vector2i(48, 110) to Vector2i(32, 72) to tighten the bottom world strip's fill within its dock. Horizontal padding reduced by 33% (48→32px each side), vertical padding reduced by 35% (110→72px). Preserves geometry-derived tile sizing from #39.
PR Review: Tighten Bottom Dock Padding (Issue #49)
Recommendation: Approve
This is a clean, focused change that reduces BOTTOM_DOCK_PADDING from Vector2i(48, 110) to Vector2i(32, 72), achieving roughly 33% horizontal and 35% vertical padding reduction for the bottom dock.
Change Summary
File: scripts/main.gd
Type: Single constant value modification
Impact: Reduces padding chrome around the world strip in bottom dock mode
"Bottom dock should stay shallow and wide" (CLAUDE.md): Reducing vertical padding (110→72) while also reducing horizontal padding directly supports keeping the dock shallower with more space for the game world.
"Denser strip filling" (Open Work Themes): This change explicitly addresses the stated open work theme by reducing dead space around the world strip.
"Dense tile strip with minimal dead space" (UX Constraints): The reduction in padding directly reduces dead space around the game strip.
Consistent with recent architecture: Git log shows this builds on PR windowstead #39: derive dock size from tile geometry #48 (tile-first dock sizing), maintaining the tile-geometry-first approach rather than sizing the dock independently.
Technical Observations
No syntax issues — GDScript constant assignment is valid
No breaking changes — purely visual/layout adjustment
No save migration needed
No dependency on external resources
Unknowns / Needs Verification
Runtime validation: No test results or headless validation provided. Repository standards mention running ./.tools/Godot_v4.2.2-stable_linux.x86_64 --headless --path . --script res://tests/test_runner.gd for validation.
Visual confirmation: No screenshots or visual evidence included to verify the change produces the intended "better world strip fill" result.
Cross-platform impact: macOS runtime validation has been important in this repo per AGENTS.md notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49. Partial fix — reduced BOTTOM_DOCK_PADDING from Vector2i(48, 110) to Vector2i(32, 72) to tighten the bottom world strip's fill within its dock. Horizontal padding reduced by 33% (48→32px each side), vertical padding reduced by 35% (110→72px). Preserves geometry-derived tile sizing from #39.