Skip to content

windowstead #40: reduce vertical dock width to hug tile column - #59

Merged
itsmiso-ai merged 2 commits into
mainfrom
fix/issue-40-vertical-dock-width
Apr 18, 2026
Merged

windowstead #40: reduce vertical dock width to hug tile column#59
itsmiso-ai merged 2 commits into
mainfrom
fix/issue-40-vertical-dock-width

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Ref #40. Reduce VERTICAL_DOCK_PADDING.x from 60 to 20 so the vertical dock width is closer to the actual tile column geometry instead of reading as ~3x wider.

Acceptance criteria met:

@smurf-bot

smurf-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Automated recommendation: APPROVE

Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1

Review: PR #59 - Reduce vertical dock width to hug tile column

Recommendation: Approve

This is a clean, targeted change that reduces VERTICAL_DOCK_PADDING.x from 60 to 20, tightening the vertical (side) dock width by 40px. The change is well-scoped, meets all acceptance criteria, and aligns with repository standards.


Change Summary

File Change
scripts/main.gd VERTICAL_DOCK_PADDING.x: 60 → 20 (40px reduction)

No other files touched. Net change: +1/-1 lines. The BOTTOM_DOCK_PADDING constant remains unchanged, confirming bottom mode is not affected.


Standards Compliance

Side dock width guidance met (AGENTS.md): "Side dock should stay modest in width, especially on ultrawide monitors." — The reduction from 60→20 achieves a tighter footprint closer to tile column geometry.

Tile-first dock sizing preserved (AGENTS.md): The change only tunes the padding constant. The geometry-derived sizing model from PR #39 (dock_size_for_anchorworld_pixel_size() + dock_padding_for_anchor()) remains intact.

Bottom/vertical mode separation respected (AGENTS.md): BOTTOM_DOCK_PADDING unchanged. Two orientation families remain distinct.

No breaking changes: This is a constants-only patch. The new value (20) is a smaller integer, which cannot cause runtime type errors. No code logic modified.


Acceptance Criteria Verification

Criteria Status Evidence
Vertical dock width reduced (40px tighter) Diff: 60→20 on x-axis = 40px reduction
Dock feels tighter to tile column in vertical mode Intent matches issue #40 and PR title
Left and right anchors use same VERTICAL_DOCK_PADDING dock_padding_for_anchor returns same constant for "left"/"right"
Bottom mode not affected BOTTOM_DOCK_PADDING unchanged in diff
Tile-first/geometry-derived sizing from #39 intact No logic changes; only padding constant modified

Unknowns / Needs Verification

None. The change is fully self-contained with complete context:

  • Diff provides the exact modification
  • PR body documents acceptance criteria with checkmarks
  • Repository history confirms issue Fix vertical dock width to match tile column geometry #40 context
  • Git grep shows VERTICAL_DOCK_PADDING usage is via dock_padding_for_anchor(), which correctly selects by anchor type

Conclusion

This is a small, correct UX polish change. The math checks out, the constants separation is maintained, and the change direction (tighter side dock) is explicitly endorsed by repository standards. Approve.

@itsmiso-ai
itsmiso-ai merged commit c15740f into main Apr 18, 2026
@itsmiso-ai
itsmiso-ai deleted the fix/issue-40-vertical-dock-width branch April 18, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant