Skip to content

joryirving/windowstead #51: reduce bottom-mode popup size for lighter overlay presence - #64

Merged
joryirving merged 3 commits into
mainfrom
fix/issue-51-popup-placement
Apr 20, 2026
Merged

joryirving/windowstead #51: reduce bottom-mode popup size for lighter overlay presence#64
joryirving merged 3 commits into
mainfrom
fix/issue-51-popup-placement

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Fixes #51. Partial fix — reduced bottom-mode popup from 240×200 to 220×180 and SIDEBAR_WIDTH from 240 to 220. Smaller popup feels less dominant over the world strip while keeping management access. Vertical mode popup unchanged.

@smurf-bot

smurf-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Automated recommendation: APPROVE

Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1

PR Review: Reduce Bottom-Mode Popup Size

Recommendation: Approve

This is a well-scoped fix addressing issue #51 by reducing the bottom-mode popup dimensions to feel less dominant over the world strip.

Change Summary

Location Before After
SIDEBAR_WIDTH constant 240 220
Bottom-mode sidebar_scroll size Vector2(240, 200) Vector2(220, 180)

Key Findings

  1. Consistent width reduction: The bottom-mode popup width is reduced from 240 to 220 pixels, matching the updated SIDEBAR_WIDTH constant. This is a coordinated, intentional change.

  2. Height also reduced: The popup height is reduced from 200 to 180 pixels, making it more compact vertically.

  3. Vertical mode unchanged: The vertical side dock popup remains Vector2(220, 300), which appears to be the existing baseline (this value predates the constant change). This is appropriate per the PR description.

  4. Minimal and surgical: Only 4 lines changed (2 additions, 2 deletions) across a single file, which is appropriate for a UI sizing adjustment.

Standards Compliance

AGENTS.md alignment: This change supports the stated design goals:

  • "Bottom dock should stay shallow and wide" — reduced height from 200 to 180
  • "Menus should be temporary popup overlays, not persistent sidebars" — smaller popup feels less intrusive
  • "The game should be glanceable, low-attention" — reduced visual dominance improves this

Unknowns / Needs Verification

None — the diff is clear, the change is consistent within the file, and the PR description accurately explains the intent.

Source References

@itsmiso-ai
itsmiso-ai force-pushed the fix/issue-51-popup-placement branch from 914fed9 to 3975be4 Compare April 18, 2026 20:40
@joryirving
joryirving merged commit 61123d2 into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tune bottom-mode popup placement and relationship to the strip

2 participants