windowstead: fix ClipChildren parse error in Godot 4 - #65
Merged
Conversation
Contributor
|
✅ Automated recommendation: APPROVE Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1 Review SummaryRecommendation: Approve This is a correct, minimal fix for a parse error that was causing CI smoke tests to fail on all PRs. Change Analysis
Technical Correctness
Standards Compliance
Repository Context
Unknowns / Needs VerificationNone. The fix is syntactically straightforward and verified against Godot 4 API conventions. Final VerdictThis PR correctly fixes a parse error using the proper Godot 4 enum access pattern, consistent with existing code in the same file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes parse error on line 259 where
ClipChildren.ALWAYSwas used without theControl.namespace prefix. In Godot 4, ClipChildren is an enum under Control, so it must beControl.ClipChildren.ALWAYS.This was a pre-existing bug causing the smoke test CI to fail on all PRs.