Skip to content

windowstead: fix ClipChildren parse error in Godot 4 - #65

Merged
itsmiso-ai merged 1 commit into
mainfrom
fix/issue-clip-children-control
Apr 18, 2026
Merged

windowstead: fix ClipChildren parse error in Godot 4#65
itsmiso-ai merged 1 commit into
mainfrom
fix/issue-clip-children-control

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Fixes parse error on line 259 where ClipChildren.ALWAYS was used without the Control. namespace prefix. In Godot 4, ClipChildren is an enum under Control, so it must be Control.ClipChildren.ALWAYS.

This was a pre-existing bug causing the smoke test CI to fail on all PRs.

@itsmiso-ai
itsmiso-ai merged commit 6f8d00f into main Apr 18, 2026
1 of 2 checks passed
@itsmiso-ai
itsmiso-ai deleted the fix/issue-clip-children-control branch April 18, 2026 20:40
@smurf-bot

smurf-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Automated recommendation: APPROVE

Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1

Review Summary

Recommendation: Approve

This is a correct, minimal fix for a parse error that was causing CI smoke tests to fail on all PRs.

Change Analysis

Aspect Finding
File scripts/main.gd
Line 259
Fix ClipChildren.ALWAYSControl.ClipChildren.ALWAYS

Technical Correctness

  • Verified: In Godot 4, ClipChildren is an enum nested under the Control class. It must be accessed via the full namespace path Control.ClipChildren.ALWAYS.
  • Consistency: The surrounding code (line 258) already uses Control.MOUSE_FILTER_STOP, confirming this pattern is established in the file.
  • No Breaking Changes: This is a bug fix; the previous syntax was incorrect and would not compile.

Standards Compliance

Standard Status
GDScript namespace conventions ✅ Follows existing pattern
Minimal targeted fix ✅ Single line change
CI fix validation ✅ Resolves smoke test failure

Repository Context

  • CI Impact: The PR description states this bug was causing the smoke test CI to fail on all PRs.
  • Git log confirms the HEAD commit: fix: use Control.ClipChildren enum in Godot 4 (parse error)
  • Test workflow (.github/workflows/test.yml:43) treats script errors as failures, validating the parse error was blocking.

Unknowns / Needs Verification

None. The fix is syntactically straightforward and verified against Godot 4 API conventions.

Final Verdict

This PR correctly fixes a parse error using the proper Godot 4 enum access pattern, consistent with existing code in the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant