Skip to content

joryirving/windowstead #52: span dock across full screen edge instead of floating panel - #66

Merged
joryirving merged 3 commits into
mainfrom
fix/issue-52-full-edge-dock
Apr 20, 2026
Merged

joryirving/windowstead #52: span dock across full screen edge instead of floating panel#66
joryirving merged 3 commits into
mainfrom
fix/issue-52-full-edge-dock

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Fixes #52. The dock window now spans the full usable screen edge: bottom mode gets full width, side mode gets full height. Tile-first board geometry is preserved — only the outer window extent is adjusted to behave like a true desktop dock rather than a floating panel.

@smurf-bot

smurf-bot Bot commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Automated recommendation: APPROVE

Analysis engine: MiniMax-M2.7@https://api.minimax.io/v1

Recommendation: Approve

This PR implements a targeted fix for issue #52, making the dock window span the full screen edge it anchors to rather than behaving like a floating panel.

Change Summary

In apply_dock_position(), after tile-first sizing is calculated, the code now expands the dock to span its anchored edge:

  • Bottom mode: Full screen width (dock_size.x = usable_rect.size.x)
  • Side modes: Full screen height (dock_size.y = usable_rect.size.y)

Standards Compliance

Requirement Status
Tile-first dock sizing preserved
Bottom dock shallow and wide
Side dock modest width
Distinct bottom vs vertical behavior

Quality

  • Minimal scope: Single file, 5-line addition
  • Clear intent: Comment explains the behavior immediately
  • Low risk: Padding is preserved on the non-spanned dimension
  • No regressions: Tile metrics calculated first; only outer extent adjusted

Unknowns

None — evidence is complete and the implementation follows established patterns in the codebase.

@joryirving
joryirving merged commit 2da8780 into main Apr 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make dock span the full anchored edge

2 participants