Standardize coinparam HDCoinType allocation #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changing these values is why I'm in favor of eagerly evaluating HD keys for each channel. So you create a "channel root key" when you create a new channel and that's kept with the channel for the life of it, and there's (almost) absolutely no way to have keys break outside of changing the root key itself. |
|
Also, does this update the |
|
I think the channel root key is a nice idea, dunno about the downsides, so need to ask others about it. Regarding |
have a randomyl set rule to prevent random assignments
delbonis
added
the
consistency
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we can refer to SLIP-044 for main net coin number and then allocate the appropriate number for regtest and testnet coins. The number 10000 was chosen hoping that there wouldn't be more than 10000 coins in existence. This can be increased if desired.
WARNING: If you're already running lit, this will not work with your regtest and mainnet coins. This does not change the behaviour of Vertcoin Mainnet in any way, so those funds are safe.
ref: #340