This repository was archived by the owner on Dec 19, 2017. It is now read-only.
Closed
Conversation
|
I was looking for exactly this PR! Any chance this can get merged for the next version? |
d478fb8 to
d01f006
Compare
d01f006 to
b1cc2d8
Compare
Author
|
thanks @davedash ! That didn't work for me but I was able to sort of get it testing, I think (within docker golang:1.4). Yet the test is failing with: # _/usr/src/myapp/rds_test
./rds_test.go:51: unknown rds.CreateDBInstance field 'StorageType' in struct literal
FAIL _/usr/src/myapp/rds [build failed]I'm sure I'm going to have egg on my face in no time as this is a n00b mistake. But I just don't see it... makes me wonder if I'm testing against the wrong rds.go file? damn. |
Owner
|
Done by #215 sorry I saw that first! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, an apology. I'm not familiar with Go and I wasn't able to figure out how to compile and run the tests. I'll continue to bang away at it, but if you wanted to add a
CONTRIBUTING.mddocument, that would be welcome :)This PR is, in part, to address hashicorp/terraform#439. While I'm figuring out the build chain, I wanted to throw this over the fence. I hope you don't mind.