ansible_mitogen: Remove restrictive whitelist of modules served from controller #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreati
changed the title
moreati
force-pushed
the
issue1011-import-handler
branch
7 times, most recently
from
4620ccb to
fb4ae24
Compare
moreati
changed the title
moreati
force-pushed
the
issue1011-import-handler
branch
from
fb4ae24 to
eb6bdaf
Compare
Current module whitelist/blacklist behaviour is to reject any module not on the whitelist if the whitelist is populated. Adding `ansible` and `ansible_mitogen` to the whitelist effectively blocklisted every other Python module/package, negating much of the benefit of Mitogen. Fixes mitogen-hq#1011
moreati
force-pushed
the
issue1011-import-handler
branch
from
eb6bdaf to
823ee90
Compare
Member
Author
|
The allow list (whitelist) entries were added in 2018 replcijng several deny list (blacklist) entries; with the intent of reducing roundtrips for modules that Mitogen was unlikely to be able to serve
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1011