-
Notifications
You must be signed in to change notification settings - Fork 19
Opaque Width #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DoeringChristian
wants to merge
7
commits into
master
Choose a base branch
from
opaque_width
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Opaque Width #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b93d79
to
04698e3
Compare
a94493f
to
c4da6f7
Compare
0c7bcb0
to
1b50da2
Compare
c4da6f7
to
ba68363
Compare
wjakob
reviewed
Mar 28, 2025
wjakob
reviewed
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on this PR (In addition, I left one before the review, see above)
ba68363
to
b25effa
Compare
bb07d99
to
3dbd62b
Compare
a948b67
to
a032a12
Compare
5c9b86d
to
669d1be
Compare
669d1be
to
4b7c51d
Compare
4b7c51d
to
25e82c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function
jit_var_opaque_width
, that constructs an opaque variable, corresponding to the width of another variable. It also notifies the ThreadState, to record and replay this operation.