Frozen Functions Kernel History #153
Merged
+205
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
reviewed
Jun 23, 2025
merlinND
reviewed
Jun 25, 2025
src/record_ts.cpp
Outdated
| } | ||
|
|
||
| state.kernel_history.append(kernel_history_entry); | ||
| } |
There was a problem hiding this comment.
If all of this code that creates the kernel history entry is very close to the existing code (in the normal kernel launch function), would it make sense to factor some of this out to a common function?
There was a problem hiding this comment.
Does it make sense for the llvm/cuda threadstate to record the kernel history entry? This is how it is recorded for other operations, such as reductions etc.
DoeringChristian
force-pushed
the
replay-kernel-history
branch
2 times, most recently
from
d6724b0 to
039b0e8
Compare
DoeringChristian
force-pushed
the
replay-kernel-history
branch
from
039b0e8 to
f043eda
Compare
wjakob
reviewed
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables frozen functions to generate kernel history entries, when replaying kernels.