Skip to content

Alert added#28

Open
ByPikod wants to merge 1 commit into
mjbvz:masterfrom
ByPikod:master
Open

Alert added#28
ByPikod wants to merge 1 commit into
mjbvz:masterfrom
ByPikod:master

Conversation

@ByPikod

@ByPikod ByPikod commented Oct 30, 2023

Copy link
Copy Markdown

Note

Following syntax is not available with the VS Code's built-in markdown preview.

> [!NOTE]
> Following syntax is not available with the VS Code's built-in markdown preview.

Thought it would be good to have this extension of mine in this package.

@mjbvz

mjbvz commented Nov 2, 2023

Copy link
Copy Markdown
Owner

Looks like a good addition! However for security reasons I can't add an extension that I don't have control over to this pack

Once microsoft/vscode#197023 lands though I can review the code for a single version of your extension and then lock this extension pack to only pick up that version (users could still manually install a newer version of the extension if they wish)

So unfortunately we are blocked until microsoft/vscode#197023 is supported

@electriquo

Copy link
Copy Markdown

relates to #23, #30

@sebanovo

Copy link
Copy Markdown

It is already implemented in visual studio code

@electriquo

Copy link
Copy Markdown

It is already implemented in visual studio code

still does not work for me in vscode. do you refer to vscode builtin without any extension?
could you please explain what do you mean?

@GersonFeDutra

Copy link
Copy Markdown

@jnovack

jnovack commented Apr 23, 2025

Copy link
Copy Markdown

@mjbvz Looks like microsoft/vscode#197023 is marked as wont-fix. Is it possible to fork yahyabatulu's open source code to repackage or even integrate into your renderer? Of course, please keep all credits and commits to the original author so they receives credit.

This lets the users install one package, and you make sure nothing sneaks in. Win-win-win.

@ex-nerd

ex-nerd commented Jun 25, 2025

Copy link
Copy Markdown

What about submitting the relevant portions of the @ByPikod extension directly to this extension? The licenses are compatible.

@AMDphreak AMDphreak mentioned this pull request Jun 30, 2025
@gbudge

gbudge commented Jan 5, 2026

Copy link
Copy Markdown

Why don't you just include the capability in your own extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants