-
Notifications
You must be signed in to change notification settings - Fork 1
Update handler for mkdocstrings 0.28 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pawamoy
wants to merge
10
commits into
master
Choose a base branch
from
mkdocstrings-028
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−36
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c65217f
Update handler for mkdocstrings 0.28
pawamoy de7b3a0
fixup! Update handler for mkdocstrings 0.28
pawamoy e60fdee
fixup! Update handler for mkdocstrings 0.28
pawamoy 172b7a3
fixup! Update handler for mkdocstrings 0.28
pawamoy 4bdc6f1
fixup! Update handler for mkdocstrings 0.28
pawamoy 019d4f6
fixup! Update handler for mkdocstrings 0.28
pawamoy c128c06
fixup! Update handler for mkdocstrings 0.28
pawamoy 24468d1
fixup! Update handler for mkdocstrings 0.28
pawamoy 161c89a
fixup! Update handler for mkdocstrings 0.28
pawamoy 16b0fa1
fixup! Update handler for mkdocstrings 0.28
pawamoy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
mkdocstrings==0.26.1 | ||
griffe==1.3.1 | ||
mkdocstrings==0.30.0 | ||
griffe==1.12.1 | ||
mkdocs-material==9.2.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
mypy==1.11.2 | ||
types-setuptools==75.* | ||
mypy==1.17.* | ||
types-setuptools==80.* | ||
types-Markdown==3.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have replicated previous behavior here, but I have to note that this seems incorrect to return both the path of the file, as well as all the procedure names within it. It's possible that the previous method (
get_anchors
) was confusing, and the "anchors" concept not well explained. The renaming toget_aliases
is to make it more clear: it's not really about HTML anchors, it's about obtaining all the different "aliases" ("locations") for a given object, to correctly populate mkdocs-autorefs data. I know nothing about VBA, but surelyProcedure1
is not an alias ofProcedure2
?Aliases (and the identifier) are supposed to be strings that you can pass to
collect
.Here I'd either just return
(data.path.as_posix(),)
(or even an empty tuple()
), or add a way to support collectingProcedure1
without a file path (or these procedure objects should expose fully qualified names that can be collected).