fix(pi): keep runtime context at system boundary - #1002
Open
Tarun-joy wants to merge 2 commits into
Open
Conversation
Author
|
Review verdict: APPROVE The revised implementation uses Pi's canonical Validated with the complete Pi adapter suite (68/68), focused Resume/Routing coverage (7/7), typecheck/build and bundle drift checks. The branch is clean, scoped to the Pi adapter and tests, current with upstream |
Tarun-joy
force-pushed
the
fix/pi-hidden-context
branch
from
July 30, 2026 01:52
cb25e81 to
4a6328a
Compare
Author
|
Revalidated after rebasing onto current upstream
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before_agent_start.systemPromptWhy
Pi's
display: falseonly controls the interactive transcript. API consumers and adapters may still reinterpret custom messages as user messages. Runtime automation is system-owned context, so it belongs in the system prompt rather than in conversation history.This intentionally favors transcript correctness and stable role semantics over the previous prompt-cache optimization.
Validation
npx vitest run tests/pi-extension.test.ts— 68 passedcontexthandler is registered