fix: support "latest" as chart version#1000
Merged
Conversation
Skip semver constraint validation when version is "latest" since it's not a valid semver string. The helm command already handles "latest" correctly by omitting the --version flag. Fixes #999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip semver constraint validation when version is "latest" since it's not a valid semver string. The helm command already handles "latest" correctly by omitting the --version flag.
Fixes #999
We were actually handling that case for getting chart version https://github.com/mkubaczyk/helmsman/blob/master/internal/app/helm_helpers.go#L46 so it totally makes sense to go same route here.