Add timings to server responses#1279
Open
spicyneuron wants to merge 5 commits into
Open
Conversation
d95da48 to
061264e
Compare
061264e to
6ba776c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
timingsobject to/v1/chat/completionsand/v1/completionsresponses so clients can measure prompt and generation throughput without instrumenting the server themselves. Useful for benchmarking, comparing models, and surfacing tps in UIs.The shape mirrors llama.cpp's
timingsfield for ecosystem compatibility:Behavior
Follows the existing
usageconventions:stream_options.include_usageis set.Implementation notes
GenerationResponse.prompt_tpsdoesn't work because batched generation has no per-sequence equivalent.prompt_nexcludes cached tokens.predicted_per_secondis0when fewer than two tokens are generated..get("include_usage")instead of["include_usage"]to avoidKeyErrorwhenstream_optionsis passed without that key.