Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlx_lm/tokenizer_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ def add_eos_token(self, token: str):
self._eos_token_ids.add(token_id)

def _find(self, tokens, sequence, start=None, end=None, reverse=False):
start = start or 0
start = max(start or 0, 0)
end = end or len(tokens)
outer_loop = (
range(end - len(sequence), start - 1, -1)
Expand Down
12 changes: 12 additions & 0 deletions tests/test_tokenizers.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,18 @@ def test_thinking(self):
self.assertIsNone(tokenizer.think_start_id)
self.assertIsNone(tokenizer.think_end_id)

def test_think_search_short_prompt_negative_start(self):
# Regression for #1326: the server computes start = len(prompt) - 11 and passes
# it to rfind_think_start. For prompts shorter than 11 tokens that start is
# negative; the think-token search must clamp it instead of indexing past the
# token list (IndexError, which the server surfaces as a 404).
tokenizer = load_tokenizer("mlx-community/Qwen3-4B-4bit")
self.assertTrue(tokenizer.has_thinking)
short_tokens = [0, 1, 2] # 3-token prompt with no think-start present
start = len(short_tokens) - 11 # = -8, exactly what server.py passes
self.assertEqual(tokenizer.rfind_think_start(short_tokens, start=start), -1)
self.assertEqual(tokenizer.find_think_start(short_tokens, start=start), -1)


if __name__ == "__main__":
unittest.main()