Skip to content

Improvements to parsing metadata links #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvements to parsing metadata links #266

wants to merge 2 commits into from

Conversation

@dpdicken
Copy link
Contributor

@dpdicken dpdicken commented Oct 20, 2021 •
edited
Loading

  • Adds and improves scripts for adding metadata into GrFN
  • Changes to parse new structure of alignment data
  • Adds Unit metadata

TODO: Still needs a fix to handle changes from #263 . Essentially, text spans are now a list of spans instead of a single span and should be handled appropriately.

@dpdicken dpdicken requested a review from titomeister October 20, 2021 19:12
titomeister
titomeister approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@titomeister titomeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titomeister titomeister titomeister approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpdicken @titomeister