Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver sort option for tags listing and delete with -keep #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ $ nexus-cli image ls
$ nexus-cli image tags -name mlabouardy/nginx
```

```
$ nexus-cli image tags -name mlabouardy/nginx -sort semver
```

```
$ nexus-cli image info -name mlabouardy/nginx -tag 1.2.0
```
Expand All @@ -80,6 +84,10 @@ $ nexus-cli image delete -name mlabouardy/nginx -tag 1.2.0
$ nexus-cli image delete -name mlabouardy/nginx -keep 4
```

```
$ nexus-cli image delete -name mlabouardy/nginx -keep 4 -sort semver
```

## Tutorials

* [Cleanup old Docker images from Nexus Repository](http://www.blog.labouardy.com/cleanup-old-docker-images-from-nexus-repository/)
60 changes: 54 additions & 6 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/mlabouardy/nexus-cli/registry"
"github.com/urfave/cli"
"github.com/blang/semver"
)

const (
Expand Down Expand Up @@ -55,6 +56,10 @@ func main() {
Name: "name, n",
Usage: "List tags by image name",
},
cli.StringFlag{
Name: "sort, s",
Usage: "Sort tags by semantic version, assuming all tags are semver except latest.",
},
},
Action: func(c *cli.Context) error {
return listTagsByImage(c)
Expand Down Expand Up @@ -88,6 +93,9 @@ func main() {
cli.StringFlag{
Name: "keep, k",
},
cli.StringFlag{
Name: "sort, s",
},
},
Action: func(c *cli.Context) error {
return deleteImage(c)
Expand Down Expand Up @@ -160,6 +168,11 @@ func listImages(c *cli.Context) error {

func listTagsByImage(c *cli.Context) error {
var imgName = c.String("name")
var sort = c.String("sort")
if sort != "semver" {
sort = "default"
}

r, err := registry.NewRegistry()
if err != nil {
return cli.NewExitError(err.Error(), 1)
Expand All @@ -169,9 +182,7 @@ func listTagsByImage(c *cli.Context) error {
}
tags, err := r.ListTagsByImage(imgName)

compareStringNumber := func(str1, str2 string) bool {
return extractNumberFromString(str1) < extractNumberFromString(str2)
}
compareStringNumber := getSortComparisonStrategy(sort)
Compare(compareStringNumber).Sort(tags)

if err != nil {
Expand Down Expand Up @@ -211,6 +222,11 @@ func deleteImage(c *cli.Context) error {
var imgName = c.String("name")
var tag = c.String("tag")
var keep = c.Int("keep")
var sort = c.String("sort")
if sort != "semver" {
sort = "default"
}

if imgName == "" {
fmt.Fprintf(c.App.Writer, "You should specify the image name\n")
cli.ShowSubcommandHelp(c)
Expand All @@ -225,10 +241,10 @@ func deleteImage(c *cli.Context) error {
cli.ShowSubcommandHelp(c)
} else {
tags, err := r.ListTagsByImage(imgName)
compareStringNumber := func(str1, str2 string) bool {
return extractNumberFromString(str1) < extractNumberFromString(str2)
}

compareStringNumber := getSortComparisonStrategy(sort)
Compare(compareStringNumber).Sort(tags)

if err != nil {
return cli.NewExitError(err.Error(), 1)
}
Expand All @@ -250,3 +266,35 @@ func deleteImage(c *cli.Context) error {
}
return nil
}

func getSortComparisonStrategy(sort string) func(str1, str2 string) bool{
var compareStringNumber func(str1, str2 string) bool

if sort == "default" {
compareStringNumber = func(str1, str2 string) bool {
return extractNumberFromString(str1) < extractNumberFromString(str2)
}
}

if sort == "semver" {
compareStringNumber = func(str1, str2 string) bool {
if str1 == "latest" {
return false
}
if str2 == "latest" {
return true
}
version1, err1 := semver.Make(str1)
if err1 != nil {
fmt.Printf("Error parsing version1: %q\n", err1)
}
version2, err2 := semver.Make(str2)
if err2 != nil {
fmt.Printf("Error parsing version2: %q\n", err2)
}
return version1.LT(version2)
}
}

return compareStringNumber
}