Fix off‑by‑one when using --max_examples in language/bert/evaluate_v1.1.py #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script provides a
--max_examplesoption to limit the number of evaluation samples.However,
totalis incremented and compared tomax_examplesbefore the per‑example score is recorded.If
--max_examplesis specified, the statistics for the final sample are skipped, so the reported metrics are based onN – 1examples instead ofN.This PR moves the
total += 1and theif max_examples and max_examples == total: breaklogic after the score update. This lets the last sample contribute to the metrics, ensuring the results accurately reflect allNexamples.