Support max-batchsize argument for resnet50 non tpu run #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
Potential help to issue mlcommons/inference#2249 |
anandhu-eng
changed the title
arjunsuresh
reviewed
Jul 15, 2025
| @@ -259,7 +260,7 @@ def get_run_cmd_reference( | |||
| scenario_extra_options + mode_extra_options + dataset_options | |||
| else: | |||
| cmd = "./run_local.sh " + env['MLC_MLPERF_BACKEND'] + ' ' + \ | |||
| env['MLC_MODEL'] + ' ' + env['MLC_MLPERF_DEVICE'] + " --scenario " + env['MLC_MLPERF_LOADGEN_SCENARIO'] + " " + env['MLC_MLPERF_LOADGEN_EXTRA_OPTIONS'] + \ | |||
| env['MLC_MODEL'] + ' ' + env['MLC_MLPERF_DEVICE'] + " --scenario " + env['MLC_MLPERF_LOADGEN_SCENARIO'] + " --max-batchsize " + env.get('MLC_MLPERF_LOADGEN_MAX_BATCHSIZE', '128') + " " + env['MLC_MLPERF_LOADGEN_EXTRA_OPTIONS'] + \ | |||
There was a problem hiding this comment.
this code portion is common for R50 and retinanet right?
There was a problem hiding this comment.
Hi @arjunsuresh , the resnet50 and retinanet uses the same main.py file. But I see that for retinanet, some default profile use batch size 1, Its better to keep it only for resnet50 as of now until we do some testing with the added tags. I have updated the code in recent PR
arjunsuresh
reviewed
Jul 22, 2025
| @@ -261,6 +262,8 @@ def get_run_cmd_reference( | |||
| cmd = "./run_local.sh " + env['MLC_MLPERF_BACKEND'] + ' ' + \ | |||
| env['MLC_MODEL'] + ' ' + env['MLC_MLPERF_DEVICE'] + " --scenario " + env['MLC_MLPERF_LOADGEN_SCENARIO'] + " " + env['MLC_MLPERF_LOADGEN_EXTRA_OPTIONS'] + \ | |||
| scenario_extra_options + mode_extra_options + dataset_options | |||
| if env['MLC_MODEL'] in ["resnet50"]: | |||
| cmd += f" --max-batchsize {env.get('MLC_MLPERF_LOADGEN_MAX_BATCHSIZE', '128')} " | |||
There was a problem hiding this comment.
in line num 66 we are supporting batchsize in MLC_MLPERF_LOADGEN_EXTRA_OPTIONS. . So, may be we should add this as a default before that line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧾 PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.