Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dataset-fashionmnist.R #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Vishwas-10
Copy link

@cregouby
Copy link
Contributor

cregouby commented Feb 3, 2025

Hello @Vishwas-10 ,

Thanks a lot for this contribution.
A lot, if not all of the code in fashion_mnist_dataset()is a duplicate of mnist_dataset(). Have you consider avoiding the duplication via a simple inherit = mnist_dataset, like in

kmnist_dataset <- dataset(
name = "kminst_dataset",
inherit = mnist_dataset,
?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants