Add MobileNet v3 model family #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cregouby
requested changes
Aug 31, 2025
R/models-mobilenetv3.R
Outdated
| #' @examples | ||
| #' \dontrun{ | ||
| #' # For pretrained weights mobilenet_v3_large | ||
| #' model_large <- model_mobilenet_v3_large(pretrained = TRUE) |
There was a problem hiding this comment.
todo example fails with
model_large <- model_mobilenet_v3_large(pretrained = TRUE)
Erreur dans initialize(...) : objet 'nn_hardswish' introuvable
>
suggestion should be linked to the remark on import from...
There was a problem hiding this comment.
I have updated the @importFrom, and have also run the code. Now it works properly. Thanks for finding the bug.
Do let me know if the error still persists.
cregouby
reviewed
Aug 31, 2025
…eashed/torchvision into feat/mobilenetv3Model
|
I have also switched to a much more useful example in the documentation.Do let me know if you want me to revert back to the previous example. |
cregouby
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two models:
with pretrained weights from
This PR also includes documentation and tests for the above mentioned models.
Closes #200