Update spi definition for Zephyr 3.2+ compatibility#10
Open
cairnm wants to merge 1 commit intommccoyd:mainfrom
Open
Update spi definition for Zephyr 3.2+ compatibility#10cairnm wants to merge 1 commit intommccoyd:mainfrom
cairnm wants to merge 1 commit intommccoyd:mainfrom
Conversation
|
I grabbed cairnm's changes and applied them to my build. I can confirm that it is functioning on my Hillside46. |
CaptainFlint42
left a comment
CaptainFlint42
left a comment
There was a problem hiding this comment.
I also applied these changes and it worked for my Hillside 52.
DaisukeAok
added a commit
to DaisukeAok/hillside
that referenced
this pull request
May 1, 2024
|
I made the same changes and worked on my Hillside 48. |
|
I have also confirmed that these changes resolve the build issue on my fork. After merging the branch to my fork the build is successful. Thanks for the fix @cairnm ! |
auipga
pushed a commit
to auipga/zmk-config-hillside52
that referenced
this pull request
Jan 5, 2025
MandarinoMcZumo
added a commit
to MandarinoMcZumo/zmk-config-hillside
that referenced
this pull request
Aug 1, 2025
rossw42
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates the SPI definition to use
&pinctrlwhich is a necessary change for ZMK using Zephyr 3.2 or greater. The update essentially replicates the example code in the ZMK docs.I've tested this change and confirmed that it builds/runs when using the current ZMK
mainbranch, and the underglow LEDs work as expected on my Hillside46.