Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+2] refactor linear_regression_raw #3008

Merged
merged 6 commits into from
Mar 17, 2016
Merged

[MRG+2] refactor linear_regression_raw #3008

merged 6 commits into from
Mar 17, 2016

Conversation

jona-sassenhagen
Copy link
Contributor

Factor out a bunch of helpers. Prerequisite for

@jona-sassenhagen jona-sassenhagen changed the title WIP: refactor linear_regression_raw [MRG] refactor linear_regression_raw Mar 11, 2016
@larsoner
Copy link
Member

LGTM

agramfort
agramfort reviewed Mar 14, 2016
View reviewed changes
mne/stats/tests/test_regression.py
@@ -91,6 +91,7 @@ def test_continuous_regression_no_overlap():
tmin, tmax = -.1, .5

raw = mne.io.Raw(raw_fname, preload=True)
raw.apply_proj()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We compare it to the regular evoked object and that one seemingly gets a projection applied (?). So this makes the objects we compare more similar. 

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check, hopefully.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does :)

@jona-sassenhagen
Copy link
Contributor Author

I think I want to factor out contructing the evokeds too, cause that makes it fairly easy to actually plugin in sklearn objects here.

And I'd like to add an example for how to combine this and sklearn for a really easy encoder model validation.

Sorry for going back and forth on MRG/WIP all the time :)

@jona-sassenhagen jona-sassenhagen changed the title [MRG] refactor linear_regression_raw [WIP] refactor linear_regression_raw Mar 16, 2016
@jona-sassenhagen jona-sassenhagen changed the title [WIP] refactor linear_regression_raw [MRG] refactor linear_regression_raw Mar 16, 2016
@jona-sassenhagen
Copy link
Contributor Author

Ready now.

@larsoner
Copy link
Member

+1 for merge

@larsoner larsoner changed the title [MRG] refactor linear_regression_raw [MRG+1] refactor linear_regression_raw Mar 16, 2016
@dengemann dengemann changed the title [MRG+1] refactor linear_regression_raw [MRG+2] refactor linear_regression_raw Mar 16, 2016
@jona-sassenhagen
Copy link
Contributor Author

The 2nd Travis build is stuck ...

@larsoner
Copy link
Member

Restarted it for you, will merge if it comes back happy

larsoner added a commit that referenced this pull request Mar 17, 2016
@larsoner
Merge pull request #3008 from jona-sassenhagen/rerp-cv
7c97459 
[MRG+2] refactor linear_regression_raw
@larsoner larsoner merged commit 7c97459 into mne-tools:master Mar 17, 2016
@larsoner
Copy link
Member

Thanks @jona-sassenhagen

@jona-sassenhagen
Copy link
Contributor Author

Thanks for reviews everyone!

@jona-sassenhagen jona-sassenhagen deleted the rerp-cv branch March 17, 2016 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jona-sassenhagen @larsoner @agramfort @dengemann @kingjr