Remove duplicates in MDP files #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user can provide a MDP file with the `-x` option. Yet, that MDP file cannot overwrite options that are defined in the default MDP template. Indeed, the option would the appear twice in the resulting MDP file, which would cause Gromacs to crash. This commit introduces option deduplication for MDP files. When an option is defined several time, only the last definition is kept. Note that the deduplication does not conserve the order, the comments, not the empty lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can provide a MDP file with the
-xoption. Yet, that MDP filecannot overwrite options that are defined in the default MDP template.
Indeed, the option would the appear twice in the resulting MDP file,
which would cause Gromacs to crash.
This commit introduces option deduplication for MDP files. When an
option is defined several time, only the last definition is kept. Note
that the deduplication does not conserve the order, the comments, not
the empty lines.