Skip to content

Mac os#13

Open
Moonbeam4520 wants to merge 3 commits into
mnurzia:masterfrom
Moonbeam4520:macOS
Open

Mac os#13
Moonbeam4520 wants to merge 3 commits into
mnurzia:masterfrom
Moonbeam4520:macOS

Conversation

@Moonbeam4520
Copy link
Copy Markdown

modified install.sh to make it work on macOS Sierra.
tested with zsh on macOS 10.12.4 (16E195).

@nicklanng
Copy link
Copy Markdown
Contributor

That branch gave me this output:

16 warnings generated.
  CCLD     dd
  CC       ls.o
  CC       ls-dir.o
  CCLD     dir
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [dir] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
mv: rename ls to /usr/bin/ls-i: No such file or directory
mv: rename dir to /usr/bin/dir-i: No such file or directory
mv: rename vdir to /usr/bin/vdir-i: No such file or directory

@Noammac
Copy link
Copy Markdown
Contributor

Noammac commented Jun 6, 2017

Removing the shebang and encoding notation from ls_colors_generator will not only make it not execute (since the shebang is used by Linux to determine what program to use to execute the file), but supposing it will be executed by python, it won't be python 2 compatible!.
Also, the addition to the ./configure line will make it break on some machines.

I propose that the install script will be smarter and check for OS before executing the commands, thus allowing for a one-file-fits-all solution.

@Moonbeam4520
Copy link
Copy Markdown
Author

oups, that was unwanted, I deleted the file by mistake and copy pasted it, so it was a mistake.
I'll investigate later on the ld error, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants