Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
📌 작업 개요
1. 기능 개선 및 추가
현재 배차 조회 API 개선:
GET /api/v1/transporter/current-dispatchofficeTelNumber) 필드 추가완료 배차 조회 API 구현: 기사가 자신의 완료된 배차 내역을 조회할 수 있는 기능
GET /api/v1/transporter/completed-dispatches- 목록 조회 (기간별 필터링)GET /api/v1/transporter/completed-dispatches/{dispatchId}- 상세 조회2. 테스트 코드 추가 (총 46개 테스트)
3. 버그 수정
@BeforeEach deleteAll()이 실제 운영 데이터를 삭제하던 심각한 버그 수정application-test.yml에 이중 안전장치 추가 (잘못된 DB URL 설정)4. 새로운 DTO
CompletedDispatchListItemRes: 완료 배차 목록 항목CompletedDispatchDetailRes: 완료 배차 상세 정보 (태그 포함)5. Repository 개선
findByIdWithTransporter(): Lazy Loading 문제 해결을 위한 Fetch Join 쿼리findDispatchesByDistance(): 거리순 배차 조회 (상태 필터 옵션)findCompletedDispatchesByTransporterIdAndDateRange(): 완료 배차 기간별 조회countAcceptedOffersByTransporter(): 기사별 ACCEPTED 제안 개수 조회findByIdWithLock(): 동시성 제어를 위한 비관적 락 쿼리✨ 기타 참고 사항
테스트 환경 개선
postgis/postgis:16-3.4)동시성 제어 검증
✅ 체크리스트
application.yml파일을 수정했다면, Notion에 업로드, github security 수정 및 공유했어요. (application-test.yml만 수정)