test: build export with compression #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
test-build-export
branch
from
c96633c to
e22d7e3
Compare
crazy-max
commented
Sep 23, 2024
| benchmarkBuildExport(b, sb, "gzip") | ||
| } | ||
| func benchmarkBuildExportZstd(b *testing.B, sb testutil.Sandbox) { | ||
| benchmarkBuildExport(b, sb, "zstd") |
There was a problem hiding this comment.
zstd compression in available since v0.10.0 so it fails for older refs like: https://github.com/moby/buildkit-bench/actions/runs/10995084553/job/30525242309?pr=146#step:8:139
BenchmarkBuild/BenchmarkBuildExportZstd/ref=v0.9.0/run=1
build_test.go:254:
Error Trace: /src/test/build_test.go:254
/src/test/build_test.go:238
/src/util/testutil/run.go:127
/src/util/testutil/run.go:253
/src/util/testutil/run.go:258
/src/util/testutil/run.go:280
/usr/local/go/src/testing/benchmark.go:193
/usr/local/go/src/testing/benchmark.go:215
/usr/local/go/src/runtime/asm_amd64.s:1695
Error: Received unexpected error:
exit status 1
Test: BenchmarkBuild/BenchmarkBuildExportZstd/ref=v0.9.0/run=1
Messages: ERROR: failed to solve: unsupported layer compression type: zstd
I will disable this benchmark for now but we could solve this with #120 or patches if that makes sense
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
test-build-export
branch
2 times, most recently
from
77f952b to
188aba2
Compare
crazy-max
commented
Sep 23, 2024
| @@ -133,7 +158,7 @@ RUN cp /etc/foo /etc/bar | |||
| fstest.CreateFile("Dockerfile", dockerfile, 0600), | |||
| fstest.CreateFile("foo", []byte("foo"), 0600), | |||
| ) | |||
| out, err := buildxBuildCmd(sb, withArgs(dir)) | |||
| out, err := buildxBuildCmd(sb, withArgs("--output=type=image", dir)) | |||
There was a problem hiding this comment.
Looks to be an oversight from me during rebase 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.