mcp: add stream type #171
Merged
mcp: add stream type #171
+86
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate several maps into a single struct. Simplifies the code, for the most part.
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the streamable server transport implementation by introducing a single stream struct to replace multiple separate maps. The main purpose is to simplify the code structure and improve maintainability by grouping related stream data together.
- Replaces three separate maps (
outgoing,signals,streamRequests) with a singlestreamsmap containingstreamstructs - Introduces a new
streamtype that encapsulates all stream-related state and behavior - Updates all stream-related operations to work with the consolidated structure
| t.mu.Unlock() | ||
|
|
||
| for _, data := range outgoing { | ||
| if err := t.opts.EventStore.Append(req.Context(), t.id, id, data); err != nil { | ||
| if err := t.opts.EventStore.Append(req.Context(), t.SessionID(), stream.id, data); err != nil { |
There was a problem hiding this comment.
Inconsistent method call: using t.SessionID() here but t.id was used in the original code. This may cause incorrect session identification in the event store.
Suggested change
| if err := t.opts.EventStore.Append(req.Context(), t.SessionID(), stream.id, data); err != nil { | |
| if err := t.opts.EventStore.Append(req.Context(), t.SessionID(), t.SessionID(), data); err != nil { |
Copilot uses AI. Check for mistakes.
samthanawalla
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate several maps into a single struct.
Simplifies the code, for the most part.