Support an HTTP GET handler for HttpServletStatelessServerTransport #643
+79
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow setting custom MCP handlers that defer to the handler that is set by the framework
Randgalt
changed the title
Randgalt
force-pushed
the
jordanz/support-get-handler
branch
3 times, most recently
from
1e8799d to
2d789f8
Compare
Currently, `HttpServletStatelessServerTransport` always returns `SC_METHOD_NOT_ALLOWED` for GET. With this change, consumers of the library can implement their own GET handler so that they can implement the Session semantics of the MCP protocol.
Randgalt
force-pushed
the
jordanz/support-get-handler
branch
from
2d789f8 to
1072617
Compare
|
We think we can do what we need without this change. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an HTTP GET handler for HttpServletStatelessServerTransport
Currently,
HttpServletStatelessServerTransportalways returnsSC_METHOD_NOT_ALLOWEDfor GET. With this change, consumers of thelibrary can implement their own GET handler so that they can implement
the Session semantics of the MCP protocol.
Note:
GetHandlerinterfaces are specific to eachMcpStatelessServerTransport. This allows the greatest flexibility and should be easier to manage/maintain.Note: I've rebased this on #641 so the first commit is duplicated here due to GitHub limitations.
Motivation and Context
Combined with #641 the library has enough primitives to implement support for MCP sessions. We would really like to add support for MCP sessions and, with these changes, can do it in our application code without any further changes to this library. Of course, if there's interest, we can contribute the changes back to this library.
How Has This Been Tested?
It's a very simple change - is a test needed?
Breaking Changes
None
Types of changes
Checklist
Additional context