Refactor func_metadata() implementation
#1496
Open
+108
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Oct 18, 2025
Comment on lines
+36
to
+37
| "typing-extensions>=4.9.0", | ||
| "typing-inspection>=0.4.1", |
There was a problem hiding this comment.
typing-extensions is already used in the project, but not declared as an explicit dependency. 4.9.0 is the oldest version with (proper) support for typing_extensions.deprecated.
typing-inspection is already a Pydantic dependency, so nothing new added here.
| if type_hints: | ||
| # Classes with type hints can be converted to Pydantic models | ||
| model = _create_model_from_class(type_annotation) | ||
| model = _create_model_from_class(type_annotation, type_hints) |
There was a problem hiding this comment.
_create_model_from_class() used to compute the type hints again, pass them to avoid unnecessarily computing them again.
Comment on lines
-471
to
-513
| def _get_typed_signature(call: Callable[..., Any]) -> inspect.Signature: | ||
| """Get function signature while evaluating forward references""" | ||
| signature = inspect.signature(call) | ||
| globalns = getattr(call, "__globals__", {}) | ||
| typed_params = [ | ||
| inspect.Parameter( | ||
| name=param.name, | ||
| kind=param.kind, | ||
| default=param.default, | ||
| annotation=_get_typed_annotation(param.annotation, globalns), | ||
| ) | ||
| for param in signature.parameters.values() | ||
| ] | ||
| typed_return = _get_typed_annotation(signature.return_annotation, globalns) | ||
| typed_signature = inspect.Signature(typed_params, return_annotation=typed_return) | ||
| return typed_signature |
There was a problem hiding this comment.
Removed, we can just use inspect.get_annotations() with eval_str=True.
It also enables more use cases to be supported, e.g.:
from __future__ import annotations
def func[T](a: T): ...
from_metadata(func) # Used to raiseLet me know if I should add a test for this.
Viicos
force-pushed
the
refactor-func-metadata
branch
from
5b71783 to
5dff9fa
Compare
Viicos
force-pushed
the
refactor-func-metadata
branch
from
5dff9fa to
cf3ae5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a first step in adding support for Pydantic 2.12 and Python 3.14. It avoids relying on patterns that we discourage using in Pydantic (mostly around the
FieldInfoclass), and removes usage of private utilities.How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context