test: use errno.ENOENT for command not found assertion #1498
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingo1996
force-pushed
the
main
branch
3 times, most recently
from
7cefe3e to
2131e25
Compare
- Replace error message text matching with errno.ENOENT check - Improves test reliability across different system languages - Removes dependency on specific error message strings"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1472
Replace error message text matching with errno.ENOENT check
Improves test reliability across different system languages
Removes dependency on specific error message strings
Motivation and Context
Test assertion fails on Chinese system locale #1472
How Has This Been Tested?
uv run pytest tests/client/test_stdio.py::test_stdio_client_nonexistent_commandResults (4.98s):
1 passed
Breaking Changes
Types of changes
Checklist
Additional context