implements the notifications/initialized method #84
Conversation
- According to https://modelcontextprotocol.io/specification/2025-06-18/basic/lifecycle, "After successful initialization, the client MUST send an initialized notification to indicate it is ready to begin normal operations". - This implementation just replies with an empty response (same as ping).
There was a problem hiding this comment.
Yeah, the current behavior that results in the following error is problematic.
{jsonrpc: "2.0", id: "123", error: {code: -32601, message: "Method not found", data: "notifications/initialized"}}
It must be able to respond to notifications/initialized in accordance with the specification.
lib/mcp/server.rb
Outdated
| @@ -66,6 +66,7 @@ def initialize( | |||
| Methods::PROMPTS_GET => method(:get_prompt), | |||
| Methods::INITIALIZE => method(:init), | |||
| Methods::PING => ->(_) { {} }, | |||
| Methods::NOTIFICATIONS_INITIALIZED => ->(_) { {} }, | |||
There was a problem hiding this comment.
Actually shouldn't this return nil (i.e. return nothing)? Notifications are special methods that don't have a response.
There was a problem hiding this comment.
test/mcp/server_test.rb
Outdated
| request = { | ||
| jsonrpc: "2.0", | ||
| method: "notifications/initialized", | ||
| id: "123", |
There was a problem hiding this comment.
An id should not be present here, since this is a notification.
There was a problem hiding this comment.
This should be implemented as an actual notification, not a method. See https://www.jsonrpc.org/specification#notification
|
I have changed it to return nil and fixed the test case to not send an |
According to https://modelcontextprotocol.io/specification/2025-06-18/basic/lifecycle, "After successful initialization, the client MUST send an initialized notification to indicate it is ready to begin normal operations".
This implementation just replies with an empty response (same as ping).
Motivation and Context
Claude Code assumed the MCP server wasn't working when this method was not handled gracefully.
How Has This Been Tested?
test case added, works in my app.
Types of changes