fix: accept stringified numeric response IDs#1021
Merged
Merged
Conversation
github-actions
Bot
added
T-test
DaleSeo
force-pushed
the
fix/stringified-response-id
branch
from
July 21, 2026 16:45
01cbcb3 to
647624a
Compare
DaleSeo
marked this pull request as ready for review
July 21, 2026 16:54
alexhancock
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1017
Motivation and Context
Some JSON-RPC gateways serialize numeric response IDs as strings, causing rmcp clients to reject valid initialization or discovery responses and leave regular requests unresolved. This change accepts a stringified numeric ID only when matching a numeric request ID, while preserving exact matching for genuine string IDs. The same correlation rule now covers startup, pending requests, and streamable HTTP cancellation bookkeeping, with regressions for exact string precedence.
How Has This Been Tested?
Added tests
Breaking Changes
None
Types of changes
Checklist