Skip to content

fix(test): classify runtime dependencies in test workspaces - #2592

Closed
SnowSky1 wants to merge 1 commit into
modelcontextprotocol:mainfrom
SnowSky1:fix/test-helpers-vitest-dependency
Closed

fix(test): classify runtime dependencies in test workspaces#2592
SnowSky1 wants to merge 1 commit into
modelcontextprotocol:mainfrom
SnowSky1:fix/test-helpers-vitest-dependency

Conversation

@SnowSky1

Copy link
Copy Markdown

Summary

  • move packages imported by executable test helpers and fixtures from devDependencies to dependencies
  • update the workspace lockfile importer classifications
  • restore the repository-wide lint:all gate

Validation

  • pnpm lint:all
  • pre-push hook: full workspace build, lint, and typecheck

The affected packages are private test workspaces, so no changeset is required.

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d11e05c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jul 31, 2026

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@2592

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@2592

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@2592

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@2592

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@2592

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@2592

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@2592

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@2592

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@2592

commit: d11e05c

@SnowSky1

Copy link
Copy Markdown
Author

@felixweinberger, when you have a chance, could you review this test-workspace manifest fix? It restores the current lint:all gate by classifying imports from executable helper/fixture source as runtime dependencies. The PR is mergeable and all CI checks are green; the packages are private, so it intentionally has no changeset.

@SnowSky1

Copy link
Copy Markdown
Author

Status note: this PR was unintentionally left as a draft while I opened the stacked #2593 draft. GitHub now disables “Ready for review” for my external account because of the repository open-PR limit, and the API denies markPullRequestReadyForReview. The diff and CI are complete; if the approach looks right, could a maintainer mark #2592 ready (or review/merge it directly)? I’ll then rebase #2593 to remove this commit.

@claude claude Bot added the v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes label Aug 18, 2026
@SnowSky1

Copy link
Copy Markdown
Author

Closing for the time being: repository permissions prevent me from marking this draft ready for review (the markPullRequestReadyForReview mutation returns FORBIDDEN for my account), and drafts cannot be merged, so I do not want it sitting idle in the review queue. The diff was complete and CI was green at close time; the branch fix/test-helpers-vitest-dependency is kept on my fork. Happy to reopen or resubmit if maintainers want this change or can restore draft-readiness for external contributors.

@SnowSky1 SnowSky1 closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant