Skip to content

Add type compatibility test between SDK and spec types #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 14, 2025
+710 −1
Merged

Add type compatibility test between SDK and spec types #729

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ead6fb5
Add type compatibility test between SDK and spec types
ochafik Jul 3, 2025
d1a30ab
disable lints in spec.types.test.ts
ochafik Jul 3, 2025
e0fc390
rename + switch position of RemovePassthrough<T>
ochafik Jul 3, 2025
b3c5d27
Update spec.types.test.ts
ochafik Jul 3, 2025
d57d35e
Update spec.types.test.ts
ochafik Jul 3, 2025
e388806
add MakeUnknownsNotOptional to fix optionality of Zod unknown() fields
ochafik Jul 3, 2025
0cd88db
Update spec.types.test.ts
ochafik Jul 3, 2025
a19175a
Update spec.types.test.ts
ochafik Jul 3, 2025
2fc1581
widen type extraction regex, introduce + test MISSING_SDK_TYPES, chec…
ochafik Jul 4, 2025
3ae5522
Update spec.types.test.ts
ochafik Jul 4, 2025
b6e00f9
Update spec.types.test.ts
ochafik Jul 4, 2025
a7e4289
Update spec.types.test.ts
ochafik Jul 4, 2025
0c0b075
Merge branch 'main' into ochafik/spec-type-tests
ochafik Jul 4, 2025
c9947a9
Merge branch 'main' into ochafik/spec-type-tests
ochafik Jul 7, 2025
98a04e6
moved src/spec.types.ts to .
ochafik Jul 7, 2025
96a4f71
removed checkResourceReference (sdk's ResourceReference is deprecated…
ochafik Jul 7, 2025
c72b52b
Merge branch 'main' into ochafik/spec-type-tests
ochafik Jul 9, 2025
cce168c
Merge branch 'main' into ochafik/spec-type-tests
ochafik Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ web_modules/
# Output of 'npm pack'
*.tgz

# Output of 'npm run fetch:spec-types'
src/spec.types.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to do it without creating a file in src?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point thx, moved it to top-level which is only marginally better. Happy to create another tmp dir if you think it's cleaner (dist seems a no-go)


# Yarn Integrity file
.yarn-integrity

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"dist"
],
"scripts": {
"fetch:spec-types": "curl -o src/spec.types.ts https://raw.githubusercontent.com/modelcontextprotocol/modelcontextprotocol/refs/heads/main/schema/draft/schema.ts",
"build": "npm run build:esm && npm run build:cjs",
"build:esm": "mkdir -p dist/esm && echo '{\"type\": \"module\"}' > dist/esm/package.json && tsc -p tsconfig.prod.json",
"build:esm:w": "npm run build:esm -- -w",
Expand All @@ -43,7 +44,7 @@
"examples:simple-server:w": "tsx --watch src/examples/server/simpleStreamableHttp.ts --oauth",
"prepack": "npm run build:esm && npm run build:cjs",
"lint": "eslint src/",
"test": "jest",
"test": "npm run fetch:spec-types && jest",
"start": "npm run server",
"server": "tsx watch --clear-screen=false src/cli.ts server",
"client": "tsx src/cli.ts client"
Expand Down
Loading