Skip to content

fix: use authorization_server_url as issuer when fetching metadata #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use authorization_server_url as issuer when fetching metadata #763

wants to merge 1 commit into from
+4 −4

Conversation

JoJoJoJoJoJoJo
Copy link

This pr resolves #762, build the well-known url with authorization_server_url rather than mcp server url when discovering metadata

Motivation and Context

See #762

How Has This Been Tested?

Tested with official github mcp server

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth metadata url building should use authorization_server as base_url rather than mcp server url
1 participant
@JoJoJoJoJoJoJo