fix: consistently use consumer-provided fetch function #767
+709
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the transports and auth to consistently use the consumer-provided fetch function, if provided.
Motivation and Context
Enables usage in environments with non-conformant fetch globals, and assists in debugging. I was passing a custom fetch function to check the request order in the auth flow, and wasn't seeing everything due to this issue.
How Has This Been Tested?
Existing unit tests plus a spot check in my debug setup.
Breaking Changes
None.
Types of changes
Checklist
Additional context
?? fetch
fallbacks in the code to avoid needing to change the unit tests. The unit tests currently rely on the fact that the global fetch is always looked up at call-time due to mocking the globalfetch
function.