Vectorized min max #3728
Merged
Vectorized min max #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Language group: Ok. |
henrikt-ma
reviewed
Nov 28, 2025
henrikt-ma
reviewed
Nov 28, 2025
henrikt-ma
reviewed
Nov 28, 2025
henrikt-ma
requested changes
Nov 28, 2025
Collaborator
henrikt-ma
left a comment
henrikt-ma
left a comment
There was a problem hiding this comment.
I think we need to avoid raising expectations on where we point out that an operator or function is vectorizable.
Co-authored-by: Henrik Tidefelt <[email protected]>
HansOlsson
added
M37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #3651 I realized that there is no real reason not to vectorize min/max with two arguments.
One use-case would be that you can ensure that each element of a vector is >=0 by using:
max(0, x).