-
Notifications
You must be signed in to change notification settings - Fork 44
List changes #3780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HansOlsson
wants to merge
7
commits into
modelica:master
Choose a base branch
from
HansOlsson:ListChanges
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−0
Open
List changes #3780
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fe3a83d
Start
HansOlsson 11f0af4
Description
HansOlsson c42d894
Description
HansOlsson 50afc49
Update 3610.md
HansOlsson f102470
MajorMinor
HansOlsson 6af5003
Apply suggestions from code review
HansOlsson 115c856
Apply suggestions from code review
HansOlsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Discrete-time variability based on `GenerateEvents` #3610 | ||
|
|
||
| ## Main change | ||
|
|
||
| Variability of functions with `GenerateEvents`. | ||
|
|
||
| ## Reason | ||
|
|
||
| Making it possible to create functions that generate events similarly as the built-in functions, and have rules consistent with them just being inlined. | ||
|
|
||
| ## Breaks | ||
|
|
||
| ``` modelica | ||
| function foo | ||
| input Real x; | ||
| output Integer i=bar(x)+(if x>0 then 1 else 0); | ||
| annotation(GenerateEvents=true); | ||
| end foo; | ||
|
|
||
| function bar | ||
| input Real x; | ||
| output Integer i=integer(x); | ||
| annotation(GenerateEvents=false); | ||
| end bar; | ||
| Integer x=foo(time); | ||
| ``` | ||
|
|
||
| The call of `bar` in `foo` is now illegal, similarly as in a model. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| This directory contains descriptions of semantic changes introduced in the various versions. | ||
|
|
||
| Clarifications, examples, reformulations, and changes in layout or other external resources will not be included in this list. | ||
|
|
||
| There are separate files for each release to make it easy to maintain during development, but the files may later be merged. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the plan was to only describe backwards incompatible changes, that is, to not add descriptions of backwards compatible new features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New features should be described separately; but I think it would still be good to include them somehow. But let's first focus on the backwards incompatible ones.