-
Notifications
You must be signed in to change notification settings - Fork 174
Setting master version to 4.2.0 dev #4659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ding the already merged OpAmp (modelica#4643 and modelica#4653)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, but some unnecessary whitespace changes, see comments.
Thanks @maltelenz I wasn't aware of these tiny whitespace changes. |
Perfectly preserving whitespace when editing is a very hard problem for a tool, so whichever tool you used I don't blame it :) I try to discard small changes like these before committing, but they can slip through the cracks easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the placeholder things are probably OK (so it is remembered to fill it out when the time comes), but this sentence seems specific to 4.1.0 and I don't think we need it.
Otherwise fine.
Co-authored-by: Malte Lenz <[email protected]>
…ter version to 4.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearly we are aiming for 4.2.0 at some point in time, but calling it 4.2.0 already will be a bit confusing. Wouldn't it be better to call it "4.2.0 Development" or similarly?
That syntax is specified in Modelica; and intended exactly for such scenarios.
I prefer the straight and clear 4.2.0. It should be clear enough that it isn't released yet by the fact that you are looking at master
, and not a release (branch or github release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not change the version now. See also #4661 as my alternate PR.
To be honest, I would prefer "4.2.0 dev" - you see even later it had been taken from master. |
If that's the consensus, I'm OK with that, even if I prefer to keep to cleaner version numbers. |
Setting version to 4.2.0 (also ModelicaTest, Complex, etc. - hope I didn't forget one)
and provide ReleaseNotes.mo for 4.2.0, including the already merged OpAmp (#4643 and #4653)