[bugfix] fix gdn conv1d#97
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the 1D convolution in the gated delta network module to include the groups parameter, calculated using the tensor parallel and context parallel sizes. The reviewer suggests using conv1d_weight.shape[0] instead of manually computing this value, as it is cleaner and more robust.
| stride=self.conv1d.stride, | ||
| padding=self.conv1d.padding, | ||
| dilation=self.conv1d.dilation, | ||
| groups=self.conv_dim // self.tp_size // cp_size, |
There was a problem hiding this comment.
Using conv1d_weight.shape[0] is more robust and cleaner than manually computing self.conv_dim // self.tp_size // cp_size. Since conv1d_weight is already sliced according to the TP and CP configurations, its first dimension dynamically represents the correct local channel size.
Suggested change
| groups=self.conv_dim // self.tp_size // cp_size, | |
| groups=conv1d_weight.shape[0], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.